Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simplify the jupyter plugin #174

Merged
merged 25 commits into from
Aug 9, 2024

Conversation

DanielSchiavini
Copy link
Collaborator

This reverts commit 50ee8e9

What I did

  • Refactored a bit the code now that we have the tests in master

How I did it

  • By removing proxy functions from javascript and calling the rpc directly from python
  • Moved the BrowserRPC up in the file and injected it into the BrowserSigner so all calls go through it

How to verify it

  • Plugin should keep on working

Description for the changelog

N/A

Cute Animal Picture

image

@DanielSchiavini DanielSchiavini self-assigned this Mar 22, 2024
@DanielSchiavini DanielSchiavini marked this pull request as draft April 25, 2024 07:09
@DanielSchiavini DanielSchiavini marked this pull request as ready for review May 6, 2024 09:02
@charles-cooper charles-cooper merged commit 4d10a59 into vyperlang:master Aug 9, 2024
7 checks passed
@DanielSchiavini DanielSchiavini deleted the jupyter branch August 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants