Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix creation of RawEvents #209

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

cfcfs
Copy link
Contributor

@cfcfs cfcfs commented May 8, 2024

What I did

Fix TypeError: RawEvent() takes no arguments occurring while retrieving logs containing unknown events.

How I did it

  • Add missing dataclass decorator to RawEvent
  • Add test to check the fix

How to verify it

The test (tests/integration/fork/test_logs.py) should pass with the fix and fail without it

Description for the changelog

Cute Animal Picture

lpJdsBz-

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Collaborator

@DanielSchiavini DanielSchiavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

tests/integration/fork/test_logs.py Outdated Show resolved Hide resolved
@charles-cooper charles-cooper merged commit 9a85898 into vyperlang:master May 8, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants