chore: update vyper 0.4.0 branch #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@charles-cooper the remaining test should be green once this is merged (pull_request_target workflow is out-of-date) |
DanielSchiavini
commented
May 13, 2024
boa/contracts/vyper/ir_executor.py
Outdated
| self.builder.extend( | ||
| f""" | ||
| if not bool({test}): | ||
| VM.vyper_source_pos = {repr(self.ir_node.source_pos)} | ||
| VM.vyper_source_pos = {repr(source and getpos(source))} |
There was a problem hiding this comment.
can we create a small utility which wraps getpos() to do this? i'd also like to see a proper branch
if source is None:
return None
return getpos(source)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Merged master, fixing tests
Cute Animal Picture