Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update expected Etherscan message #287

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

DanielSchiavini
Copy link
Collaborator

@DanielSchiavini DanielSchiavini commented Aug 27, 2024

What I did

  • Updated the expected rate limit message
  • Ethercan can return one of:
    • {'status': '0', 'message': 'NOTOK', 'result': 'Max calls per sec rate limit reached (X/sec)'} example
    • {'status': '0', 'message': 'NOTOK', 'result': 'Max rate limit reached'} (existing code)
    • {'status': '0', 'message': 'NOTOK', 'result': 'Max rate limit reached, please use API Key for higher rate limit'} (reference)

How I did it

  • Checking the status of the response
  • Checking the error message

Cute Animal Picture

image

boa/explorer.py Outdated Show resolved Hide resolved
@charles-cooper charles-cooper merged commit 7143c2b into master Aug 28, 2024
12 of 14 checks passed
@charles-cooper charles-cooper deleted the etherscan-msg branch August 28, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants