feat: VVM injection, internal functions and variables #294
Conversation
depends on vyperlang/vvm#21
|
I'm waiting for vyperlang/vvm#21 and vyperlang/vvm#23 before finishing this PR |
DanielSchiavini
changed the title
| return None | ||
|
|
||
| result = vvm.compile_source( | ||
| self.source_code, vyper_version=self.vyper_version, output_format="metadata" |
There was a problem hiding this comment.
why don't we just get metadata to begin with (when generating VVMDeployer)?
also, note that metadata isn't available in all versions of vyper, and it is not guaranteed to be stable between releases. but this probably works for recent vyper versions (0.3.7-0.3.10)
There was a problem hiding this comment.
For what it's worth I would have no objection to restricting the scope of the VVM functionalities to 0.3.7+
There was a problem hiding this comment.
why don't we just get metadata to begin with (when generating VVMDeployer)?
Can we do that without calling the compiler twice? I implemented it here so it's only done when necessary (note the cached_property)
also, note that metadata isn't available in all versions of Vyper
We'll show the error from the compiler, so it should be clear when not supported
not guaranteed to be stable between releases
If you way to get info about private functions that's stable please let me know
There was a problem hiding this comment.
why don't we just get metadata to begin with (when generating VVMDeployer)?
Can we do that without calling the compiler twice? I implemented it here so it's only done when necessary (note the
cached_property)
ah, maybe we should have added the option for multiple output formats in vvm
DanielSchiavini
changed the title
boa/util/cached_vvm.py
Outdated
There was a problem hiding this comment.
not sure that we need this to be a separate file really
| self.contract = contract | ||
|
|
||
| def get(self, *args): | ||
| return self.__call__(*args) |
There was a problem hiding this comment.
this doesn't really work the same way as VyperContract.get()
boa/contracts/vvm/vvm_contract.py
Outdated
| def __call__(self, *args, **kwargs): | ||
| env = self.contract.env | ||
| assert isinstance(self.contract, VVMContract) # help mypy | ||
| env.set_code(self.contract.address, self._override_bytecode) |
There was a problem hiding this comment.
uhh i think this is wrong if there is a callback into the contract's code
There was a problem hiding this comment.
the rest of the contract should still behave the same even if we injected one method
What I did
inject_function,internaland_storagecontract methods for any contract compiled via the VVMHow I did it
Cute Animal Picture