-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow uint256 as iterator type in range-based for loop #2180
Allow uint256 as iterator type in range-based for loop #2180
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2180 +/- ##
=======================================
Coverage 85.32% 85.33%
=======================================
Files 83 83
Lines 8403 8405 +2
Branches 2032 2032
=======================================
+ Hits 7170 7172 +2
Misses 731 731
Partials 502 502
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a few tests and g2g
Codecov Report
@@ Coverage Diff @@
## master #2180 +/- ##
==========================================
- Coverage 85.32% 85.28% -0.05%
==========================================
Files 83 79 -4
Lines 8403 8221 -182
Branches 2032 2005 -27
==========================================
- Hits 7170 7011 -159
+ Misses 731 711 -20
+ Partials 502 499 -3
Continue to review full report at Codecov.
|
Why'd coverage go down so much here? EDIT: premature update from codecov |
There is a very minor loss to coverage in |
What I did
Allow use of types other than
int128
for range-based for loops.Fixes #2153
Fixes #2185
How I did it
This was already made possible in the type checking pass, but it gets blocked in
parser.stmt
. The proper solution is to refactor parser, but that is still potentially months away. As a stopgap solution:int128
.parser
generates smaller ASTs later in the compilation phase, without any type checking), default toint128
How to verify it
Run tests.
Cute Animal Picture