test: tests for functionality fixed in #2471

[tserg]

What I did

PR for various tests associated with #2471

How I did it

Iterate through the list of functionalities fixed.

How to verify it

Run the test suite.

Description for the changelog

Cute Animal Picture

[tserg]

Hi, I am working on the tests for #2454 and have added the test cases for uint8. Seeking some feedback on whether I am in the right direction before I proceed further.

[codecov-commenter]

Codecov Report

Merging #2568 (13a95f5) into master (c843b68) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2568      +/-   ##
==========================================
+ Coverage   85.66%   85.69%   +0.02%     
==========================================
  Files          90       90              
  Lines        9036     9036              
  Branches     2328     2328              
==========================================
+ Hits         7741     7743       +2     
+ Misses        814      813       -1     
+ Partials      481      480       -1     

Impacted Files	Coverage Δ
vyper/lll/compile_lll.py	94.72% <0.00%> (ø)
vyper/old_codegen/abi.py	71.14% <0.00%> (+0.65%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c843b68...13a95f5. Read the comment docs.

[tserg]

I have added a test case for #2455. It seems that the nonreentrant decorator is invoked even on a callback from an unprotected function without any nonreentrant decorator (see unprotected_function in test_nonreentrant_decorator_for_default under tests/parser/features/decorators/test_nonreentrant.py). I am not sure if this is intended behaviour or not.

[tserg]

I have added a test case for #2455. It seems that the nonreentrant decorator is invoked even on a callback from an unprotected function without any nonreentrant decorator (see unprotected_function in test_nonreentrant_decorator_for_default under tests/parser/features/decorators/test_nonreentrant.py). I am not sure if this is intended behaviour or not.

Update: This behaviour is not intended. The callback transaction reverted due to out of gas. Changing to raw_call() resolved the issue. The test has been updated and the behaviour is now working as intended. Further, the documentation has been updated to recommend against using the @nonreentrant(<key>) decorator on the __default__ function. Thanks to @fubuloubu and @charles-cooper for guidance.

[charles-cooper]

Left a couple questions, for the most part looks great! Thank you

[charles-cooper]

I wonder if there is some way to parametrize these tests across types?

[tserg]

Do you mean something like this: def test_{type}_too_long()?