-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: tests for functionality fixed in #2471 #2568
Conversation
Hi, I am working on the tests for #2454 and have added the test cases for |
Codecov Report
@@ Coverage Diff @@
## master #2568 +/- ##
==========================================
+ Coverage 85.66% 85.69% +0.02%
==========================================
Files 90 90
Lines 9036 9036
Branches 2328 2328
==========================================
+ Hits 7741 7743 +2
+ Misses 814 813 -1
+ Partials 481 480 -1
Continue to review full report at Codecov.
|
I have added a test case for #2455. It seems that the nonreentrant decorator is invoked even on a callback from an unprotected function without any nonreentrant decorator (see |
Update: This behaviour is not intended. The callback transaction reverted due to out of gas. Changing to |
Co-authored-by: El De-dog-lo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple questions, for the most part looks great! Thank you
tests/parser/features/external_contracts/test_external_contract_calls.py
Outdated
Show resolved
Hide resolved
|
||
|
||
@pytest.mark.parametrize("type", ["uint256", "int256"]) | ||
def test_address_too_long(get_contract, assert_tx_failed, type): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there is some way to parametrize these tests across types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean something like this: def test_{type}_too_long()
?
What I did
PR for various tests associated with #2471
How I did it
Iterate through the list of functionalities fixed.
How to verify it
Run the test suite.
Description for the changelog
Cute Animal Picture