-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vyper signature to bytecode #2860
add vyper signature to bytecode #2860
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2860 +/- ##
==========================================
+ Coverage 87.67% 87.68% +0.01%
==========================================
Files 94 94
Lines 10183 10193 +10
Branches 2501 2503 +2
==========================================
+ Hits 8928 8938 +10
Misses 790 790
Partials 465 465
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as I hate it:
- Probably should be a VIP
- Probably should align with Solidity's metadata system (but obviously without the OS-specific hash) so that decoders don't get borked up when trying to detect why there are extra unused bytes in Vyper contracts now
Co-authored-by: El De-dog-lo <[email protected]>
Issue being raised looks like it's not exported as part of |
the new offset introduced a small bug with symbol resolver, should be fixed now |
@charles-cooper I just reviewed an article about Vyper from @cairoeth that still assumed that the format is >>> sig = b"\xa1\x65vyper\x83".hex()
>>> version = "00" + "03" + "07"
>>> sig + version
'a165767970657283000307' Could you please update your description above so we don't get any confusion anymore? |
@pcaversaccio edited! |
Thx! |
FWIW, the signature has been removed from the runtime bytecode and is added to the end of the init code for Vyper |
What I did
add a vyper signature to vyper bytecode. this makes it easier to identify on block explorers
the format is
VYPR
+ major, minor, patch. for instance, a vyper 0.3.4 signature will beEDIT:
How I did it
How to verify it
compile a vyper contract and look at the end of the bytecode
Commit message
Description for the changelog
Cute Animal Picture