chore: note Context.in_assertion is dead
#3564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the Context has an `in_assertion` flag which, when set, indicates that the context should be constant according to is_constant() definition. however, this flag is never set during code generation, specifically, it is possible to have non-constant expression in an assert statement. For example, the following contract compiles: ``` x: uint256 @internal def bar() -> uint256: self.x = 1 return self.x @external def foo(): assert self.bar() == 1 ``` chainsec june review 5.5
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3564 +/- ##
==========================================
+ Coverage 89.13% 89.15% +0.01%
==========================================
Files 85 85
Lines 11365 11365
Branches 2585 2585
==========================================
+ Hits 10130 10132 +2
+ Misses 813 812 -1
+ Partials 422 421 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
charles-cooper
force-pushed
the
chore/note-dead-code
branch
2 times, most recently
from
febcdd1
to
998d2f0
Compare
fubuloubu
approved these changes
Aug 31, 2023
charles-cooper
changed the title
Context.in_assertion is deadContext.in_assertion is dead
charles-cooper
changed the title
Context.in_assertion is deadContext.in_assertion is dead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Context class has an
in_assertionflag which, when set, indicates that the context should be constant according to is_constant() definition. however, this flag is never set during code generation, specifically, it is possible to have non-constant expression in an assert statement. For example, the following contract compiles:chainsec june 2023 review 5.5
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture