fix: metadata journal can rollback incorrectly #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
call register_update when node has already been updated in this "frame" note this does not change any observed functionality in the compiler because writes to the metadata journal inside for loops only ever happen to be written once, but it prevents a bug in case we ever add mutating writes inside of the same metadata journal frame. chainsec june review 5.3
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3569 +/- ##
==========================================
- Coverage 89.13% 89.09% -0.04%
==========================================
Files 85 85
Lines 11365 11388 +23
Branches 2585 2586 +1
==========================================
+ Hits 10130 10146 +16
- Misses 813 820 +7
Partials 422 422
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fubuloubu
approved these changes
Aug 28, 2023
this commit fixes an issue where multiple writes inside of a checkpoint lead to journal corruption on rollback. in particular, it ensures a call to `register_update()` when the metadata dict has already been updated inside of a given checkpoint. note this does not change any observed functionality in the compiler because writes to the metadata journal inside for loops only ever happen to be written once, but it prevents a bug in case we ever add multiple writes inside of the same checkpoint. chainsec june review 5.3
charles-cooper
force-pushed
the
fix/metadata-update
branch
from
940e3ad
to
fcdafa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call register_update when node has already been updated in this "frame"
note this does not change any observed functionality in the compiler because writes to the metadata journal inside for loops only ever happen to be written once, but it prevents a bug in case we ever add mutating writes inside of the same metadata journal frame.
chainsec june 2023 review 5.3
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture