Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ecadd() and ecmul() codegen #3587

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Sep 5, 2023

slight cleanup: refactor ecadd and ecmul to use make_setter and share code, so we don't need to do pointer arithmetic

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

refactor ecadd and ecmul to use make_setter and share code, so we don't
need to do pointer arithmetic
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Merging #3587 (b378478) into master (78fa8dd) will decrease coverage by 0.33%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3587      +/-   ##
==========================================
- Coverage   89.10%   88.77%   -0.33%     
==========================================
  Files          85       85              
  Lines       11390    11385       -5     
  Branches     2586     2585       -1     
==========================================
- Hits        10149    10107      -42     
- Misses        817      852      +35     
- Partials      424      426       +2     
Files Changed Coverage Δ
vyper/builtins/functions.py 90.52% <100.00%> (-0.04%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper changed the title refactor: ecadd and ecmul refactor: ecadd() and ecmul() codegen Sep 5, 2023
@charles-cooper charles-cooper merged commit 3900ec0 into vyperlang:master Sep 5, 2023
76 of 77 checks passed
@charles-cooper charles-cooper deleted the refactor/ec-builtins branch September 5, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants