Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow value= passing for delegate and static raw_calls #3755

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

charles-cooper
Copy link
Member

What I did

per title. also removed a couple unneeded expr traces

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56b0d4f) 84.78% compared to head (b19b651) 84.71%.
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3755      +/-   ##
==========================================
- Coverage   84.78%   84.71%   -0.08%     
==========================================
  Files          92       92              
  Lines       13137    13141       +4     
  Branches     2929     2930       +1     
==========================================
- Hits        11138    11132       -6     
- Misses       1535     1544       +9     
- Partials      464      465       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper changed the title fix: disallow value= passing for delegate and static raw_calls fix: disallow value= passing for delegate and static raw_calls Jan 31, 2024
@charles-cooper charles-cooper merged commit a2df088 into vyperlang:master Jan 31, 2024
84 checks passed
@charles-cooper charles-cooper deleted the fix/raw_call branch January 31, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants