Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add n_slots to storage variables #3788

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Feb 19, 2024

What I did

cc @ritzdorf @trocher

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Contributor

@trocher trocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have n_slot for the non-reentrant lock as well for the sake of completeness although it would always be 1?
Otherwise LGTM

@charles-cooper
Copy link
Member Author

Would it make sense to have n_slot for the non-reentrant lock as well for the sake of completeness although it would always be 1? Otherwise LGTM

hm yea, although we didn't really save the number of slots allocated for the reentrancy key anywhere

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d2a682) 84.99% compared to head (a1e97b1) 68.91%.
Report is 7 commits behind head on master.

❗ Current head a1e97b1 differs from pull request most recent head f435166. Consider uploading reports for the commit f435166 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3788       +/-   ##
===========================================
- Coverage   84.99%   68.91%   -16.09%     
===========================================
  Files          92       92               
  Lines       13717    13717               
  Branches     3079     3079               
===========================================
- Hits        11659     9453     -2206     
- Misses       1570     3555     +1985     
- Partials      488      709      +221     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper
Copy link
Member Author

closing in favor of #3789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants