Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Investigating test performance #3806

Closed
wants to merge 45 commits into from

Conversation

DanielSchiavini
Copy link
Contributor

@DanielSchiavini DanielSchiavini commented Feb 23, 2024

Do not merge. This is just a test to profile the test performance.

SVG Graphs may be downloaded from this build with py-evm and this build with py-revm

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 89.08%. Comparing base (977ad79) to head (e92ffd6).
Report is 54 commits behind head on master.

Files Patch % Lines
vyper/ast/pre_parser.py 84.61% 3 Missing and 1 partial ⚠️
vyper/codegen/expr.py 93.22% 2 Missing and 2 partials ⚠️
vyper/ast/nodes.py 96.80% 1 Missing and 2 partials ⚠️
vyper/builtins/_convert.py 88.23% 1 Missing and 1 partial ⚠️
vyper/ast/parse.py 94.73% 0 Missing and 1 partial ⚠️
vyper/cli/vyper_compile.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3806      +/-   ##
==========================================
+ Coverage   85.03%   89.08%   +4.05%     
==========================================
  Files          92       95       +3     
  Lines       13769    14387     +618     
  Branches     3083     3186     +103     
==========================================
+ Hits        11708    12817    +1109     
+ Misses       1572     1120     -452     
+ Partials      489      450      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented Apr 3, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +33 53.3 MB carver, fselmo, kclowes, ...2 more
pypi/[email protected] None 0 34.8 MB charles-cooper, draganrakita
pypi/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +20 25.1 MB ahldev, eeaston

🚮 Removed packages: pypi/[email protected], pypi/[email protected]

View full report↗︎

Copy link

socket-security bot commented Apr 3, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Potential typo squat pypi/[email protected]

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

)
return function(*args, value=value, gas=gas, sender=sender, transact=transact, **kwargs)

def _pick_overload(self, *args, disambiguate_signature=None, **kwargs) -> ABIFunction:

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note test

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
error = f"Missing keyword argument {e} for `{self.signature}`. Passed {args} {kwargs}"
raise TypeError(error)

def __call__(self, *args, value=0, gas=None, sender=None, transact=None, call=None, **kwargs):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note test

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
tests/revm/revm_env.py Fixed Show fixed Hide fixed
@DanielSchiavini DanielSchiavini deleted the performance branch April 4, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants