fix[venom]: promote additional memory locations to variables #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4039 +/- ##
==========================================
- Coverage 91.22% 90.31% -0.92%
==========================================
Files 108 108
Lines 15522 15543 +21
Branches 3410 3416 +6
==========================================
- Hits 14160 14037 -123
- Misses 930 1043 +113
- Partials 432 463 +31 ☔ View full report in Codecov by Sentry. |
helps readability -- they are variables, not addresses!
|
lgtm, @harkal lmk if you are ok with the changes i made and i will merge |
charles-cooper
approved these changes
Oct 4, 2024
|
lgtm |
|
some nice gains: vs master: |
pcaversaccio
added a commit
to pcaversaccio/snekmate
that referenced
this pull request
Oct 11, 2024
### 🕓 Changelog This commit adds a Bash script, `generate_gas_snapshot.sh`, that includes version and configuration information into the gas snapshot files to improve traceability. Specifically, it prepends the `vyper` commit version, the `forge` commit version, and `vyper` configuration settings (e.g. optimisation mode) to the `snapshot` files. The script also supports generating snapshots for the `default-venom` profile using the `--venom` flag. Eventually, we pin the specific `vyper` commit [`d8f4032355773cd5e57e8902bd50808490de39b5`](vyperlang/vyper@d8f4032) as the subsequent commit [`fdc05d6029816ef57294e98753d9a3d60c761ab8`](vyperlang/vyper@fdc05d6) (PR [#4039](vyperlang/vyper#4039)) currently breaks our `venom`-based tests (refer to issue [#4288](vyperlang/vyper#4288) for details). --------- Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture