-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[ux]: move exception hint to the end of the message #4154
feat[ux]: move exception hint to the end of the message #4154
Conversation
Given how close the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4154 +/- ##
===========================================
- Coverage 91.35% 46.17% -45.18%
===========================================
Files 109 109
Lines 15635 15641 +6
Branches 3443 3443
===========================================
- Hits 14283 7222 -7061
- Misses 920 7866 +6946
- Partials 432 553 +121 ☔ View full report in Codecov by Sentry. |
The current version changes the |
moved the `(hint: ...)` to be reported at the end of the exception to improve the readability. the hint should be displayed after the actual problem has been described, i.e. as the last item in the exception message. --------- Co-authored-by: Charles Cooper <[email protected]>
What I did
(hint: ...)
to be reported as the last item to improve the readabilityexample:
original:
new order:
edit: fix the example
How to verify it
Commit message
Description for the changelog
Cute Animal Picture