Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[codegen]: fix abi_encode buffer size in external calls #4202

Merged

Conversation

cyberthirst
Copy link
Collaborator

@cyberthirst cyberthirst commented Aug 2, 2024

What I did

Commit Message

fix the buffer size passed to the abi encoder from the external call
argument packer. previously, the size was overestimated as it didn't
take into account pointer arithmetic performed on the buffer passed to
abi_encode.

this is a hygienic fix, no security implications were found for this
issue.

@cyberthirst cyberthirst added this to the v0.4.1 milestone Aug 5, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (c0cf436) to head (385be9c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4202      +/-   ##
==========================================
- Coverage   91.32%   88.80%   -2.53%     
==========================================
  Files         109      109              
  Lines       15625    15627       +2     
  Branches     3442     3442              
==========================================
- Hits        14270    13878     -392     
- Misses        924     1240     +316     
- Partials      431      509      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper changed the title fix[codegen]: fix bufsz passed to abi_encode in pack_args fix[codegen]: fix abi_encode buffer size in external calls Aug 6, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) August 6, 2024 03:44
@charles-cooper charles-cooper merged commit 3a83666 into vyperlang:master Aug 6, 2024
158 of 159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Buffer Size Passed to abi_encode()
2 participants