Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[lang]: show user error in error map #4286
base: master
Are you sure you want to change the base?
fix[lang]: show user error in error map #4286
Changes from 7 commits
9941a3c
2e956f8
7f314c8
38256dd
667484d
de43af9
861e6fd
3b1018f
4cfb5cd
a4b29d8
50efebf
41b726f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if some of the arguments have their own error message? Then it gets overwritten although it might be more specific.
eg in the case of
raise self.bar(5 % i)
the mod is annotated with asafemod
error msg, which will be replaced withuser revert with reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I did implement set_error_msg to override, but that could be changed. @sandbubbles could you change that in this PR to not override? And add @cyberthirst's test case
raise self.foo(5%i)
to the test suite.Check warning on line 161 in vyper/codegen/stmt.py
Codecov / codecov/patch
vyper/codegen/stmt.py#L159-L161