refactor[venom]: move dfs order to CFGAnalysis
#4330
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4330 +/- ##
===========================================
- Coverage 91.30% 46.13% -45.18%
===========================================
Files 112 112
Lines 15921 15916 -5
Branches 2691 2684 -7
===========================================
- Hits 14537 7343 -7194
- Misses 949 8018 +7069
- Partials 435 555 +120 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
it is redundant with CFGAnalysis cfg_out
this shaves 1.5% off bytecode size
| @@ -1,8 +1,7 @@ | |||
| from typing import Iterator, Optional | |||
|
|
|||
| from vyper.codegen.ir_node import IRnode | |||
| from vyper.utils import OrderedSet | |||
| from vyper.venom.basicblock import CFG_ALTERING_INSTRUCTIONS, IRBasicBlock, IRLabel, IRVariable | |||
| from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable | |||
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
| @@ -1,8 +1,7 @@ | |||
| from typing import Iterator, Optional | |||
|
|
|||
| from vyper.codegen.ir_node import IRnode | |||
| from vyper.utils import OrderedSet | |||
| from vyper.venom.basicblock import CFG_ALTERING_INSTRUCTIONS, IRBasicBlock, IRLabel, IRVariable | |||
| from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable | |||
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
| @@ -1,8 +1,7 @@ | |||
| from typing import Iterator, Optional | |||
|
|
|||
| from vyper.codegen.ir_node import IRnode | |||
| from vyper.utils import OrderedSet | |||
| from vyper.venom.basicblock import CFG_ALTERING_INSTRUCTIONS, IRBasicBlock, IRLabel, IRVariable | |||
| from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable | |||
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
shared code between remove_unreachable_blocks and sccp
| @@ -308,7 +314,7 @@ def _generate_evm_for_basicblock_r( | |||
|
|
|||
| ref.extend(asm) | |||
|
|
|||
| for bb in basicblock.reachable: | |||
| for bb in basicblock.cfg_out: | |||
There was a problem hiding this comment.
Could be reachable removed from basic block if it is no longer used here?
|
hmm, this creates a regression in |
What I did
move dfs order calculation from domtree to cfg analysis.
remove unnecessary calculation of domtree in sccp
remove redundant
IRFunction.compute_reachabilitychange cfg_out order
refactor shared phi fixup code
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture