GH actions pls

vzarytovskii · Nov 20, 2023 · 2bc0fc7 · 2bc0fc7
1 parent d09a36c
commit 2bc0fc7
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/.github/workflows/check_release_notes.yml b/.github/workflows/check_release_notes.yml
@@ -99,8 +99,7 @@ jobs:
         RELEASE_NOTES_FOUND=""
         RELEASE_NOTES_CHANGES_SUMMARY=""
         RELEASE_NOTES_NOT_FOUND=""
-        PULL_REQUEST_FOUND=false
-
+        PULL_REQUEST_FOUND=true
 
         _modified_paths=`gh pr view ${PR_NUMBER} --json files --jq '.files.[].path'`
 
@@ -130,12 +129,12 @@ jobs:
                         echo "                  Found pull request URL in $release_notes once"
                         RELEASE_NOTES_FOUND+="> | \\\`$path\\\` | \\\`[$release_notes](${FSHARP_REPO_URL}/$release_notes)\\\` | |"
                         RELEASE_NOTES_FOUND+=$'\n'
-                        PULL_REQUEST_FOUND=true
                     elif [[ ${_pr_link_occurences} -eq 0 ]]; then
                         echo "                  Did not find pull request URL in $release_notes"
                         DESCRIPTION="**No current pull request URL (${PR_URL}) found, please consider adding it**"
-                        RELEASE_NOTES_FOUND+="| \\\`$path\\\` | \\\`[$release_notes](${FSHARP_REPO_URL}/$release_notes)\\\` | ${DESCRIPTION} |"
+                        RELEASE_NOTES_FOUND+="> | \\\`$path\\\` | \\\`[$release_notes](${FSHARP_REPO_URL}/$release_notes)\\\` | ${DESCRIPTION} |"
                         RELEASE_NOTES_FOUND+=$'\n'
+                        PULL_REQUEST_FOUND=false
                     fi
                 else
                     echo "          Did not find $release_notes in modified files"
@@ -192,17 +191,21 @@ jobs:
             RELEASE_NOTES_MESSAGE_DETAILS+=$"> :white_check_mark: Found changes and release notes in following paths:"
             RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
             RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
-            RELEASE_NOTES_MESSAGE_DETAILS+=$"> [!WARNING]"
-            RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
-            RELEASE_NOTES_MESSAGE_DETAILS+=$"> **No PR link found in some release notes, please consider adding it.**"
-            RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
-            RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
-            RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
+
+            if [[ $PULL_REQUEST_FOUND = false ]]; then
+                RELEASE_NOTES_MESSAGE_DETAILS+=$"> [!WARNING]"
+                RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
+                RELEASE_NOTES_MESSAGE_DETAILS+=$"> **No PR link found in some release notes, please consider adding it.**"
+                RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
+                RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
+                RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
+            fi
+
             RELEASE_NOTES_MESSAGE_DETAILS+='> | Change path      | Release notes path | Description |'
             RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
             RELEASE_NOTES_MESSAGE_DETAILS+='> | ---------------- | ------------------ | ----------- |'
             RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
-            RELEASE_NOTES_MESSAGE_DETAILS+="> ${RELEASE_NOTES_FOUND}"
+            RELEASE_NOTES_MESSAGE_DETAILS+="${RELEASE_NOTES_FOUND}"
             RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
         fi