Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Web3dev's deployment of Forem to latest version #6

Open
wants to merge 1,101 commits into
base: web3dev-version
Choose a base branch
from

Conversation

cancelei
Copy link
Collaborator

@cancelei cancelei commented Aug 21, 2024

Type of Pull Request:

Bug Fix
New Feature
-> Others

What does this PR do?
Admins from Web3dev reported that their Forem deployment was outdated. This PR brings the correct code to deploy an updated version.

Updated target branch from main to 'web3dev-version'.

The original PR also includes a mechanism to create a Docker Image, that was removed due to stakeholder prioritization.

Additional Context

When running the repo locally without containers use the rails command to build the db from the existing schema.
To start: Run Redis locally and use bin/setup then bin/startup (to run the app locally again).

With Docker container (with running docker) :
gem install dip
dip provision (builds the image)
dip rails s

Result:
image

Closes Issue
null

lightalloy and others added 30 commits March 27, 2024 13:03
* Auto confirm flag reactions when spam role is assigned

* Renamed method according to its point

---------

Co-authored-by: Mac Siri <[email protected]>
* add test to mark profile as spam

* rubocop

* move test
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
* Move calculating comments score from worker to a service

* Display displayed comments count in feed

* Recalculating displayed comments counts on article show (if needed)

* Rubocop fixes

* Fixed lambda
)

* Initial controller creation

* Ahoy custom clicks initial WIP

* Add test for success and failure

* Adjust some tests

* Adjust test

* Adjust tests and some code

* Update app/views/mailers/digest_mailer/digest_email.html.erb

* Remove s/t/u from safe params

* Add simple test

* Update app/controllers/ahoy/custom_email_clicks_controller.rb

Co-authored-by: Mac Siri <[email protected]>

* Change to just email clicks

* Email clicks controller test

---------

Co-authored-by: Mac Siri <[email protected]>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…ot confirmed (forem#20831)

* Show reconfirmation option on users profile

* spec
* Replace edge extension

* Put name attributes at the top for consistency
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <[email protected]>
@nomadbitcoin
Copy link

@cancelei , first off, thank you for your contribution!

Could you provide more context about what this PR is addressing? While I recall you are working on updating the Forem version, other team members might not have that context, and even I might not remember all the details in the future.

It's helpful to include a clear summary of what you've done and the reasoning behind it, even if it feels redundant compared to your commit messages. Providing this information ensures the whole team is on the same page and makes it easier to review and track the purpose of the changes later on.

For reference, here's a good example from one of our other repositories: PR #153.

@nomadbitcoin
Copy link

I believe this PR should be directed to the web3dev-version branch rather than main. Could you update it accordingly?

@cancelei cancelei changed the base branch from main to web3dev-version September 6, 2024 19:43
@cancelei cancelei changed the title Cancelei/updated Update Web3Dev's Forem Deployment with updated code from Forem/Main Sep 6, 2024
@cancelei cancelei changed the title Update Web3Dev's Forem Deployment with updated code from Forem/Main Updates Web3dev's deployment of Forem to latest version Sep 6, 2024
benhalpern and others added 17 commits September 9, 2024 13:35
* More throttling for billboard tabulating

* Update app/controllers/billboard_events_controller.rb
* Add role targeting to billboards

* Complete form

* Complete form

* Fix api spec

* Finalize tests
* Add bb param to billboards after save

* Handle edge cases
* Add proper self-serve subscription cancel flow

* Make tweak to billboard display
* Track external email clicks via redirect

* Gem upgrades

* Add ahoy to vcl logic
@nomadbitcoin nomadbitcoin temporarily deployed to pt-w3d-commu-cancelei-u-bopbsc October 2, 2024 18:29 Inactive
@nomadbitcoin nomadbitcoin temporarily deployed to pt-w3d-commu-cancelei-u-5lr40w October 2, 2024 23:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.