Implement Language Metadata Filtering #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danicuki
approved these changes
Jul 26, 2024
| @@ -39,7 +39,7 @@ export function CourseCard({ course }) { | |||
| <Button auto color={''} bordered rounded icon={<BiTimeFive />}> | |||
| <Text weight={'bold'} size={'$xs'}> | |||
| {' '} | |||
| {course.duration}{' '} | |||
| <RenderField object={course} field="duration" isHtml={true} maxSize={200} /> | |||
There was a problem hiding this comment.
Why is this field HTML? Text only is OK here I believe
| @@ -50,7 +50,7 @@ export function CourseCard({ course }) { | |||
| </Button> | |||
| </Link> | |||
| <Button color={'success'} rounded flat size={'xs'}> | |||
| {course.difficulty} | |||
| <RenderField object={course} field="difficulty" isHtml={true} maxSize={200} /> | |||
| @@ -2,13 +2,10 @@ import { useTranslation } from 'react-i18next' | |||
|
|
|||
| export default function RenderField({ object, field, isHtml, maxSize }) { | |||
| const { i18n } = useTranslation() | |||
| let content | |||
| const defaultLanguage = 'en' | |||
There was a problem hiding this comment.
Should not have hardcoded default language to 'en'. This config should come from i18n definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Closes #181