Enhancement: Auto-register new students via URL parameter #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nomadbitcoin
force-pushed
the
chore/course-auto-registration
branch
from
cf0fe1d
to
629e1cf
Compare
danicuki
approved these changes
Sep 20, 2024
| @@ -55,7 +58,8 @@ function Course({ course, currentDate }) { | |||
| }, [user, cohort]) | |||
| useEffect(async () => { | |||
| if (cohorts) { | |||
| setCohort(getCurrentCohort(user, cohorts, course, currentDate)) | |||
There was a problem hiding this comment.
Don't need to change this. Inlined looks better for me
| @@ -241,6 +246,21 @@ function Course({ course, currentDate }) { | |||
| }) | |||
| } | |||
|
|
|||
| useEffect(() => { | |||
| const autoSubscribe = async () => { | |||
| if (auto_subscribe === 'true' && user && cohort && !userIsRegisteredInCurrentCohort()) { | |||
There was a problem hiding this comment.
JavaScript convention uses camel case for variables (autoSubscribe in this case)
Name of the function is the same, so needs to find better naming also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
The type of this pull request is:
What does this PR do?
This PR introduces a new feature that allows users to automatically register for a course via a URL parameter. This feature is intended for use on landing pages where users have already reviewed the course information. When users click "Subscribe now" and log in, they will be automatically enrolled in the course, removing the need to revisit the course information and click "Subscribe" again.