Fix user storage to avoid saving empty data #252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
The type of this pull request is:
What does this PR do?
This commit addresses a critical issue where users were being stored in Firestore without their full names when connecting via Google or GitHub. The main changes include:
In context/AuthContext.js:
loginGithub
function to handle GitHub authenticationhandleGithubLogin
to manage the GitHub login process, including user creation and updateIn lib/user.js:
createUserinFirestore
to check for existing users before creationThese changes resolve the issue of missing user names in Firestore, improve error handling, and ensure a more robust authentication flow across different providers (email, Google, and GitHub).