Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow auto-reauthentication in FedCM #458

Merged
merged 9 commits into from
May 9, 2023
Merged

Allow auto-reauthentication in FedCM #458

merged 9 commits into from
May 9, 2023

Conversation

npm1
Copy link
Collaborator

@npm1 npm1 commented Apr 26, 2023

Fixes #429


Preview | Diff

@npm1 npm1 requested a review from yi-gu April 26, 2023 16:32
@yi-gu
Copy link
Collaborator

yi-gu commented Apr 26, 2023

Do we need to update the algorithm to take mediation requirements into account? Or can it be implied?

@cbiesinger
Copy link
Collaborator

Do we need to update the algorithm to take mediation requirements into account? Or can it be implied?

Pretty sure we do, the algorithm is currently normatively requiring showing a dialog e.g. in step 7 of https://fedidcg.github.io/FedCM/#create-an-identitycredential

@npm1
Copy link
Collaborator Author

npm1 commented Apr 26, 2023

Hmm I thought we might get the logic for free from credential management but this appears to not be the case. We currently have all our stuff in collecting Credentials from the credential store since it requires the user to tell the user agent what IDP and account they would like to use. Credential management would only work for free if we had some of the logic in asking the user to choose a Credential. But I don't think we can move this because otherwise having only 1 possible credential with mediation equal to "optional" or "silent" would mean that we sign in the user without them having provided any consent before. So we probably need to keep doing all our stuff in collecting Credentials from the credential store and our asking the user to choose a Credential is a no-op, but that does mean we need to specify the logic in the spec. I can take a stab at it in this PR.

@npm1
Copy link
Collaborator Author

npm1 commented Apr 26, 2023

Ok, I took a stab at it, please take a look? I can loop in Mozilla folks once it looks good to you.

@npm1 npm1 changed the title Remove note about mediation not being used Allow auto-reauthentication in FedCM Apr 26, 2023
spec/index.bs Show resolved Hide resolved
@npm1
Copy link
Collaborator Author

npm1 commented Apr 27, 2023

@bvandersloot-mozilla @cboozar @martinthomson - requesting Mozilla review! As y'all had requested, we're not filing a standards position issue. So consider this it :) Please take a look.

spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
@cboozar
Copy link

cboozar commented May 9, 2023

I think these changes make sense, not sure why some of the variables needed shortening but readable either way

@npm1
Copy link
Collaborator Author

npm1 commented May 9, 2023

Thanks for the review, Cameron! Merging then. Re variable shortening, perhaps you mean acc, the reason is that I wanted it to be different from account and I'm bad at coming up with names. Happy to get suggestions on the naming.

@npm1 npm1 merged commit 6ca279e into main May 9, 2023
@npm1 npm1 deleted the mediation branch May 9, 2023 15:31
github-actions bot added a commit that referenced this pull request May 9, 2023
SHA: 6ca279e
Reason: push, by npm1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning users have to unnecessarily re-approve
4 participants