Specify the continuation API #662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMissEm
reviewed
Oct 3, 2024
| way. | ||
| 1. Wait for one of the following conditions: | ||
| * The user closes the browsing context: return failure. | ||
| * {{IdentityProvider}}.{{IdentityProvider/close}} is called in the |
There was a problem hiding this comment.
Should this actually be a reject() if the completion mechanism is resolve() — borrowing naming from Promises?
There was a problem hiding this comment.
Ah yeah, that sounds nicer to me too!
There was a problem hiding this comment.
That or something like abort(reason?: string) and finish(token: string, accountId?: string)
|
I'm glad to see this idea being implemented! |
samuelgoto
approved these changes
Oct 3, 2024
samuelgoto
reviewed
Oct 3, 2024
| @@ -1240,9 +1240,25 @@ To <dfn>fetch an identity assertion</dfn> given a {{USVString}} | |||
| 1. [=converted to an IDL value|Convert=] |json| to an {{IdentityProviderToken}}, |token|. | |||
| 1. If one of the previous two steps threw an exception, set |credential| to failure | |||
| and return. | |||
| 1. If neither {{IdentityProviderToken/token}} nor {{IdentityProviderToken/continue_on}} was | |||
| specified, set |credential| to failure and return. | |||
| 1. If {{IdentityProviderToken/token}} was not specified but | |||
There was a problem hiding this comment.
Just small nit and for clarity, but I'd return early here:
Suggested change
| 1. If {{IdentityProviderToken/token}} was not specified but | |
| 1. If {{IdentityProviderToken/token}} was specified | |
| 1. let |tokenString| be |token|'s {{IdentityProviderToken/token}}. | |
| 1. else |
There was a problem hiding this comment.
should that be 1. Else if {{IdentityProviderToken/continue_on}} was specified: ?
I think the Otherwise also would need to be removed with this change (L1256)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: w3c-fedid/custom-requests#1
Preview | Diff