Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Update a variable with set, not let #415

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Dec 11, 2023

Per https://infra.spec.whatwg.org/#variables

No behavior changes, this is purely editorial even though it touches an algorithm.


Preview | Diff

@inexorabletash
Copy link
Member Author

@a-sully can you review? Very very low priority.

@inexorabletash
Copy link
Member Author

inexorabletash commented Dec 11, 2023

Check failure likely due to bikeshed update. I'll take a peek.

Filed speced/bikeshed#2733

Copy link
Contributor

@a-sully a-sully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@inexorabletash inexorabletash merged commit 010ecb2 into main Dec 12, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Dec 12, 2023
SHA: 010ecb2
Reason: push, by inexorabletash

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants