Skip to content

Commit

Permalink
Drop 'potential-navigation-or-subresource request'. (#1486)
Browse files Browse the repository at this point in the history
https://github.com/whatwg/fetch/pull/948/files is changing `<embed>` and `<object>` requests to
look more like navigations than subresource requests. As a result, it seems reasonable for service
worker to explicitly carve out those request destinations which have behavior service worker cares
about, rather than relying on a fetch-level concept that doesn't make sense in the new model.
  • Loading branch information
mikewest authored and jakearchibald committed Dec 13, 2019
1 parent c4661d0 commit f4915e6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -2245,7 +2245,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe

The implementers are encouraged to note:

* Plug-ins should not load via [=/service workers=]. As plug-ins may get their security origins from their own urls, the embedding [=/service worker=] cannot handle it. For this reason, the <a>Handle Fetch</a> algorithm makes the <a>potential-navigation-or-subresource request</a> (whose context is either <code>&lt;embed&gt;</code> or <code>&lt;object&gt;</code>) immediately fallback to the network without dispatching {{fetch!!event}} event.
* Plug-ins should not load via [=/service workers=]. As plug-ins may get their security origins from their own urls, the embedding [=/service worker=] cannot handle it. For this reason, the <a>Handle Fetch</a> algorithm makes <code>&lt;embed&gt;</code> and <code>&lt;object&gt;</code> requests immediately fallback to the network without dispatching {{fetch!!event}} event.
* Some of the legacy networking stack code may need to be carefully audited to understand the ramifications of interactions with [=/service workers=].
</section>

Expand Down Expand Up @@ -2932,7 +2932,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
1. Let |preloadResponse| be a new [=promise=].
1. Let |fetchInstance| be the instance of the [=/fetch=] algorithm representing the ongoing fetch.
1. Assert: |request|'s [=request/destination=] is not "<code>serviceworker</code>".
1. If |request| is a <a>potential-navigation-or-subresource request</a>, then:
1. If |request|'s [=request/destination=] is either "<code>embed</code>" or "<code>object</code>", then:
1. Return null.
1. Else if |request| is a <a>non-subresource request</a>, then:

Expand Down

0 comments on commit f4915e6

Please sign in to comment.