Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unregister algorithm step 6.1 is no longer necessary #855

Closed
wanderview opened this issue Mar 25, 2016 · 1 comment
Closed

Unregister algorithm step 6.1 is no longer necessary #855

wanderview opened this issue Mar 25, 2016 · 1 comment
Labels
decided
Milestone
Version 1

Comments

@wanderview
Copy link
Member

Step 6.1 of the Unregister algorithm is:

If registration’s uninstalling flag is unset, invoke Finish Job with job and abort these steps.

I don't think this can ever be true now, though. The uninstalling flag is now cleared in the Register algorithm which executes within a job. Since we have a single job queue the flag cannot be cleared until the Unregister job completes.
hwine pushed a commit to mozilla/gecko-dev that referenced this issue Apr 6, 2016
@wanderview
Bug 1256428 P13 Remove unnecessary ServiceWorkerUnregsterJob2 stop. r…
e12c361 
…=jdm

See: w3c/ServiceWorker#855
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Apr 8, 2016
@wanderview
Bug 1256428 P13 Remove unnecessary ServiceWorkerUnregsterJob2 stop. r…
e6441d3 
…=jdm

See: w3c/ServiceWorker#855
jryans pushed a commit to jryans/gecko-dev that referenced this issue Apr 12, 2016
@wanderview
Bug 1256428 P13 Remove unnecessary ServiceWorkerUnregsterJob2 stop. r…
e2536e1 
…=jdm

See: w3c/ServiceWorker#855
@jakearchibald jakearchibald added this to the Version 1 milestone Jul 25, 2016
@jakearchibald jakearchibald mentioned this issue Jul 27, 2016
Closed
@jakearchibald
Copy link
Contributor

Pre F2F notes: Confirm this. Seems right.

gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Sep 30, 2019
@marco-c
Bug 1256428 P13 Remove unnecessary ServiceWorkerUnregsterJob2 stop. r…
517099c 
…=jdm

See: w3c/ServiceWorker#855

UltraBlame original commit: 3624db0bbe3f66f470613f94ca91534f73a92705
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Sep 30, 2019
@marco-c
Bug 1256428 P13 Remove unnecessary ServiceWorkerUnregsterJob2 stop. r…
ff7d742 
…=jdm

See: w3c/ServiceWorker#855

UltraBlame original commit: 3624db0bbe3f66f470613f94ca91534f73a92705
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Sep 30, 2019
@marco-c
Bug 1256428 P13 Remove unnecessary ServiceWorkerUnregsterJob2 stop. r…
c72815f 
…=jdm

See: w3c/ServiceWorker#855

UltraBlame original commit: 3624db0bbe3f66f470613f94ca91534f73a92705
rmottola added a commit to rmottola/Arctic-Fox that referenced this issue Apr 30, 2024
@rmottola
Bug 1256428 P13 Remove unnecessary ServiceWorkerUnregsterJob2 stop. r…
05d0717 
…=jdm

See: w3c/ServiceWorker#855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decided
Projects
None yet
Milestone
Version 1
Development

No branches or pull requests
2 participants
@jakearchibald @wanderview