Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should UA check for updates on navigate when there is no fetch event? #905

Closed
wanderview opened this issue May 28, 2016 · 4 comments
Closed

should UA check for updates on navigate when there is no fetch event? #905

wanderview opened this issue May 28, 2016 · 4 comments
Labels
decided
Milestone
Version 1

Comments

@wanderview
Copy link
Member

Currently we trigger updates for events fired at the SW. In particular, navigates always trigger updates.

Now that we allow the browser to avoid firing fetch events if there is no fetch handler, should the update still be triggered?

Per the spec, I think the answer is no. I think for dev UX, though, we should still trigger updates. It would be nice to be consistent across browsers here.
@mfalken
Copy link
Member

mfalken commented May 31, 2016

The Chrome implementation at https://bugs.chromium.org/p/chromium/issues/detail?id=605844 triggers update.

@jakearchibald jakearchibald added this to the Version 1 milestone Jul 25, 2016
@jakearchibald
Copy link
Contributor

Agree that we should trigger update on navigate within scope regardless of fetch event.

@jakearchibald jakearchibald mentioned this issue Jul 27, 2016
Closed
@jakearchibald
Copy link
Contributor

F2F: Yes.

@slightlyoff
Copy link
Contributor

LGTM.

jungkees added a commit that referenced this issue Nov 17, 2016
@jungkees
Add more Soft Update on functional events
29ae596 
This changes Handle Fetch and Handle Functional Event to invoke Soft
Update even if the service worker doesn't have any event listener
registered for the event. (Note that the cases where the request falls
back to network still do not trigger Soft Update.)

Fixes #905.
@jungkees jungkees mentioned this issue Nov 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decided
Projects
None yet
Milestone
Version 1
Development

No branches or pull requests
4 participants
@jakearchibald @slightlyoff @wanderview @mfalken