-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "sensor permission name" #40
Conversation
Sync with changes in: w3c/sensors@7cea69d
Not directly related to Accelerometer, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
@@ -182,7 +183,7 @@ The <dfn id="accelerometer-sensor-type">Accelerometer</dfn> <a>sensor type</a>'s | |||
|
|||
The <a>Accelerometer</a> has a [=default sensor=], which is the device's main accelerometer sensor. | |||
|
|||
The <a>Accelerometer</a> has an associated {{PermissionName}} which is <a for="PermissionName" enum-value>"accelerometer"</a>. | |||
The <a>Accelerometer</a> has an associated [=sensor permission name=] which is <a for="PermissionName" enum-value>"accelerometer"</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.w3.org/TR/permissions/#permission-name does not exist, should we fix https://w3c.github.io/sensors/#sensor-permission-names first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A possible fix that would not require upstream changes would be to link to https://www.w3.org/TR/permissions/#dom-permissiondescriptor-name in https://w3c.github.io/sensors/#sensor-permission-names
I don't know why there's no "permission name" dfn similarly to "permission state" in the Permissions API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that's confusing :/ let'me provide a quick fix for the Generic Sensor API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sync with changes in:
w3c/sensors@7cea69d
I'll propagate this change to other concrete specs when we're happy with this.
Preview | Diff