Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "sensor permission name" #40

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Use "sensor permission name" #40

merged 1 commit into from
Mar 1, 2018

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented Mar 1, 2018

Sync with changes in:
w3c/sensors@7cea69d

I'll propagate this change to other concrete specs when we're happy with this.


Preview | Diff

@riju
Copy link
Contributor

riju commented Mar 1, 2018

Not directly related to Accelerometer, but
Proximity spec does not have a permission name associated with it yet.
But I guess we can add a speculative "proximity-sensor" as placeholder.

w3c/proximity#32

Copy link

@pozdnyakov pozdnyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@@ -182,7 +183,7 @@ The <dfn id="accelerometer-sensor-type">Accelerometer</dfn> <a>sensor type</a>'s

The <a>Accelerometer</a> has a [=default sensor=], which is the device's main accelerometer sensor.

The <a>Accelerometer</a> has an associated {{PermissionName}} which is <a for="PermissionName" enum-value>"accelerometer"</a>.
The <a>Accelerometer</a> has an associated [=sensor permission name=] which is <a for="PermissionName" enum-value>"accelerometer"</a>.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A possible fix that would not require upstream changes would be to link to https://www.w3.org/TR/permissions/#dom-permissiondescriptor-name in https://w3c.github.io/sensors/#sensor-permission-names

I don't know why there's no "permission name" dfn similarly to "permission state" in the Permissions API.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's confusing :/ let'me provide a quick fix for the Generic Sensor API

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anssiko anssiko merged commit fe8aef4 into gh-pages Mar 1, 2018
@anssiko anssiko deleted the sensor_permission_name branch March 1, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants