-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerated and check in examples/index.html #1079
Comments
@nschonni my impression is that this should be easy to add to the deploy, but looking at the |
You might be able to commit with a |
Another thought would be to skip checking the generated file into master at all, and just generate it for the gh-pages branch. |
One reason why I want it in master is because it then feeds our other publication branches, e.g., we merge from master into apg-1.2, and later apg-1.3. However, since we don't do that often, I guess that can be manual as I just did for the working draft prep. If it is a much smaller and simpler ask, perhaps just generate automatically for the gh-pages branch. |
@mcking65 were you wanting it so you'd get a diff when merging other branches? |
…t is run The command to regenerate is: npm run build The new lint command is: npm run lint:build Document this in the README. Run the new lint in Travis CI to ensure that PRs that change something under examples/ also regenerate the index. Fixes #1079.
I would prefer one of the following:
The other approaches discussed above seem like they could result in things getting out of sync or otherwise be hard to follow what's going on, in my opinion. Since @mcking65 said he wanted the file checked in to master, I've implemented the enforcement option in #1365. |
… would change it (pull #1524) Resolves #1079: * chore: GitHub Action to check examples index.html * fix: sync examples/index.html * chore: run lint-staged for reference-table files Co-authored-by: Matt King <[email protected]>
… would change it (pull #1524) Resolves #1079: * chore: GitHub Action to check examples index.html * fix: sync examples/index.html * chore: run lint-staged for reference-table files Co-authored-by: Matt King <[email protected]>
When merging into master, we should auto-generate and check
examples/index.html
into master. Can this happen in the travis deploy script?The text was updated successfully, but these errors were encountered: