Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox examples with both and list autocomplete: Editing value in text input does not correctly update suggestion list #1332

Closed
mcking65 opened this issue Feb 16, 2020 · 1 comment · Fixed by #1335
Assignees
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Milestone

Comments

@mcking65
Copy link
Contributor

Editing the value in the combobox input is not correctly updating the listbox to have the correct set of suggested values in the combobox examples with list and both autocomplete:

  1. autocomplete = both example
  2. autocomplete = list example

The following tests are failing.

Test 1

  1. Load the combobox with autocomplete = both example
  2. Focus the combobox and type "a".
  3. Type backspace to delete the auto-highlighted text "labama"
  4. Press backspace to delete the "a".
  5. Press down arrow.

Expected result: There are 56 suggested values in the listbox and "Alabama" is selected.

Actual result: there are 5 suggested values in the listbox and "Alabama" is selected.

Test 2

  1. Load the combobox with autocomplete = both example
  2. Focus the combobox and type "no".
  3. Press Backspace to delete the auto-highlighted text "rth Carolina"
  4. Press backspace to delete the "o".
  5. Press down arrow.

Expected result: There are 9 suggested values in the listbox and "Nebraska" is selected.

Actual result: there are 3 suggested values in the listbox and "North Carolina" is selected.

Test 3

  1. Load the combobox with list autocomplete example.
  2. Focus the combobox and type "a".
  3. Press backspace to delete the "a".
  4. Press down arrow.

Expected result: There are 56 suggested values in the listbox and "Alabama" is selected.

Actual result: there are 5 suggested values in the listbox and "Alabama" is selected.

Test 4

  1. Load the combobox with list autocomplete example.
  2. Focus the combobox and type "no".
  3. Press backspace to delete the "o".
  4. Press down arrow.

Expected result: There are 9 suggested values in the listbox and "Nebraska" is selected.

Actual result: there are 3 suggested values in the listbox and "North Carolina" is selected.

@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Feb 16, 2020
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Feb 16, 2020
@jongund
Copy link
Contributor

jongund commented Feb 16, 2020

@mcking65

Just made a pull request to fix this bug.

mcking65 added a commit that referenced this issue Feb 28, 2020
…updating (pull #1335)

* fixed #1332 by adding call to filterOptions after updating filter
* added update filterOptions when ever backspace is pressed

Co-authored-by: Matt King <[email protected]>
michael-n-cooper pushed a commit that referenced this issue Feb 28, 2020
Combobox with list and both autocomplete: Fix issue with listbox not updating (pull #1335)

* fixed #1332 by adding call to filterOptions after updating filter
* added update filterOptions when ever backspace is pressed

Co-authored-by: Matt King <[email protected]>
carmacleod pushed a commit to carmacleod/aria-practices that referenced this issue Feb 29, 2020
…updating (pull w3c#1335)

* fixed w3c#1332 by adding call to filterOptions after updating filter
* added update filterOptions when ever backspace is pressed

Co-authored-by: Matt King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants