Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete gh-pages branch: Feedback on redirect presentation and code quality #2651

Closed
yatil opened this issue Mar 29, 2023 · 6 comments
Closed
Labels
Feedback Issue raised by or for collecting input from people outside APG task force Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation

Comments

@yatil
Copy link

yatil commented Mar 29, 2023

https://w3c.github.io/aria-practices/ produces a span soup that is worth a full meal. I understand that this is not glamorous work, but it is a little embarrassing.

Found via Twitter.

@lloydi
Copy link

lloydi commented Mar 29, 2023

And given the amount of ids that are present in the markup, this is clearly something that has been automated. As such, would it not have made more sense to dynamically create a server-side redirect (.htaccess or whatever) that would silently point people in the right direction for each link instead of providing the (almost) list?

@yatil
Copy link
Author

yatil commented Mar 29, 2023

Yeah, redirects on GitHub are complicated, but honestly for this case a meta refresh redirect would be sufficient. It can surely be better handled than whatever this is.

@mcking65
Copy link
Contributor

mcking65 commented Apr 2, 2023

A PR that would improve the situation is welcome!!!

With so many high impact issues in the APG Task Force backlog, the primary objective for this change was get the job done as fast as possible. This is a surface that should soon have zero traffic. It is already very low. In other words, it is little more than a stopgap backstop to help in situations where people have not updated inbound links.

It was scripted b/c there are 74 html files in the gh-pages branch that needed to have redirect info. Most of the others are in the examples/ tree and contain a single link. The index.html represents the old TR doc, and each of the links represents one of the H2 or H3 headings in that doc.

@mcking65 mcking65 added Feedback Issue raised by or for collecting input from people outside APG task force Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation labels Apr 2, 2023
@mcking65 mcking65 changed the title Redirect page(s): What’s up with the code? Obsolete gh-pages branch: Feedback on redirect presentation and code quality Apr 2, 2023
@yatil
Copy link
Author

yatil commented Apr 2, 2023

If you let me know where to send my invoice for learning how this repository works and make the necessary changes, I’m happy to contribute a Pull Request.

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Obsolete gh-pages branch: Feedback on redirect presentation and code quality · Issue #2651 · w3c/aria-practices.

The full IRC log of that discussion <jugglinmike> Subtopic: Obsolete gh-pages branch: Feedback on redirect presentation and code quality · Issue #2651 · w3c/aria-practices
<jugglinmike> github: https://github.com//issues/2651
<jugglinmike> Matt_King: The issue is that the gh-pages (where we previously had the editor's draft of the editor's doc)--we just trimmed that down
<jugglinmike> Matt_King: This is a page that a lot of people used to refer to
<jugglinmike> Matt_King: But the goal is for eventually this to receive zero traffic
<jugglinmike> Matt_King: It used to have a lot of sections and headings; a section for every pattern, etc.
<jugglinmike> Matt_King: People may have linked directly to those sections
<jugglinmike> Matt_King: The new version provides links to the specific pages that we've since created
<jugglinmike> Matt_King: People have taken issue with the way that it's coded
<jamesn> q+
<jamesn> ack me
<jugglinmike> The group is considering closing this as a "won't fix" if a pull request is not received in a few weeks' time.

@yatil yatil closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2023
@yatil
Copy link
Author

yatil commented May 12, 2023

🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback Issue raised by or for collecting input from people outside APG task force Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Development

No branches or pull requests

4 participants