-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Regression Test Fix #1285
Conversation
Signed-off-by: Evan Yamanishi <[email protected]>
Will this change force running all the tests?
|
That should still work, though I haven't tested it. You can also target specific files if you like, now that the npm script doesn't contain the file glob. # windows path
npm run regression -- test\tests\carousel_carousel-1.js |
@spectranaut @sh0ji Evan thanks for this fix, it is working in Windows now and I can run individual test files using the method you describe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the problem I had running tests in Windows 10 and I also tested on macOS and the change in configuration seems to be working there too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, runs in CI and locally on my linux machine!
This just moves the test globbing to the Ava configuration, which should solve issues where Windows wasn't able to find files.
Some background: npm
scripts
will run command line operations, leveraging whatever syntax features the operating system has in place, which results intest/tests/*.js does not exist.
on Windows. This change forces Ava to use its own internal globbing algorithm (globby), which has cross-platform support.