Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated guidance for carousel pattern #1372

Closed
wants to merge 13 commits into from
Closed

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Apr 13, 2020

Updated guidance for Carousel pattern, including a table of the different options available in the two examples.

Preview of carousel guidance changes


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Apr 22, 2020, 3:53 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL


😭  Sorry, there was an error generating the HTML. Please report this issue!
�[36mSpecification: https://rawcdn.githack.com/w3c/aria-practices/2016baa0f94ac77fbb6f44a1d51f6ed18d102ba4/aria-practices.html?isPreview=true&publishDate=2020-04-22�[39m
�[36mReSpec version: 25.6.0�[39m
�[36mFile a bug: https://github.com/w3c/respec/�[39m
�[36mError: Error: Evaluation failed: Timeout: document.respecIsReady didn't resolve in 26467ms.�[39m
�[36m    at ExecutionContext._evaluateInternal (/u/spec-generator/node_modules/puppeteer/lib/ExecutionContext.js:122:13)�[39m
�[36m    at runMicrotasks (<anonymous>)�[39m
�[36m    at processTicksAndRejections (internal/process/task_queues.js:97:5)�[39m
�[36m    at async ExecutionContext.evaluate (/u/spec-generator/node_modules/puppeteer/lib/ExecutionContext.js:48:12)�[39m
�[36m    at async generateHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:128:12)�[39m
�[36m    at async fetchAndWrite (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:95:18)�[39m
�[36m    at async Object.generate [as respec] (/u/spec-generator/generators/respec.js:14:20)�[39m
�[36m    at async generate (/u/spec-generator/server.js:91:29)�[39m
�[36m  -- ASYNC --�[39m
�[36m    at ExecutionContext.<anonymous> (/u/spec-generator/node_modules/puppeteer/lib/helper.js:111:15)�[39m
�[36m    at DOMWorld.evaluate (/u/spec-generator/node_modules/puppeteer/lib/DOMWorld.js:112:20)�[39m
�[36m    at runMicrotasks (<anonymous>)�[39m
�[36m    at processTicksAndRejections (internal/process/task_queues.js:97:5)�[39m
�[36m  -- ASYNC --�[39m
�[36m    at Frame.<anonymous> (/u/spec-generator/node_modules/puppeteer/lib/helper.js:111:15)�[39m
�[36m    at Page.evaluate (/u/spec-generator/node_modules/puppeteer/lib/Page.js:860:43)�[39m
�[36m    at Page.<anonymous> (/u/spec-generator/node_modules/puppeteer/lib/helper.js:112:23)�[39m
�[36m    at generateHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:128:23)�[39m
�[36m    at runMicrotasks (<anonymous>)�[39m
�[36m    at processTicksAndRejections (internal/process/task_queues.js:97:5)�[39m
�[36m    at async fetchAndWrite (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:95:18)�[39m
�[36m    at async Object.generate [as respec] (/u/spec-generator/generators/respec.js:14:20)�[39m
�[36m    at async generate (/u/spec-generator/server.js:91:29)�[39m
�[36m�[39m

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@mcking65 mcking65 marked this pull request as draft August 9, 2020 21:11
@mcking65
Copy link
Contributor

mcking65 commented Aug 9, 2020

@jongund, reviewing this as I'm looking at all open carousel issues and PRs. I think some of the additional content may be helpful. However, the presentation deviates significantly from other patterns.

Before spending more time on this, it would be good to discuss objectives and collectively decide what to include and where.

Unfortunately, I find the table very hard to understand. I don't think we need it. I think it is simpler to present the user with display options in the context of the example page.

@jongund
Copy link
Contributor Author

jongund commented Aug 11, 2020

@mcking65
This PR is over 4 months old, before the options in the examples was finalized.
I think the first priority should be getting the updated previous/next carousel example approved and merged.
The main thing I was trying to do with the table is help identify all the options and having links to the various options for each example, since it is easier for people to copy the URL of the example with the options they want to share with other people. Maybe not a big deal, but easier for people to do for that task.

@jongund
Copy link
Contributor Author

jongund commented Oct 25, 2020

No longer relevant.

@jongund jongund closed this Oct 25, 2020
@zcorpan zcorpan deleted the update-carousel-guidance branch May 31, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants