chore: Allow spellchecking to fail the build #1497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmacleod
approved these changes
Aug 19, 2020
|
Not sure we want this ... will add one more complexity to merging, and we already struggle with the weight of current complexities. If spellcheck is informative, then we won't have multiple PRs modifying the exceptions. We can instead occasionally review/modify exceptions and make changes in batches. One thing we should do as part of editorial review is look at the result of spellcheck test and see if any of the failures are due to mistakes in the PR being reviewed. If the PR contains content that requires a spelling exception, I'd rather not be forced to make that change to speellcheck in that PR. Net, it doesn't have to be a required check to be useful. What are some counter arguments? |
|
I'm going to close this one in favour of #1520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This landed awhile ago with it being allowed to fail. I think it's been around awhile and the instances where is started to fail PRs were valid rather than false positives, so I think it's OK to enable this now to fail PRs