Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Disable push builds for Dependabot #1551

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Oct 1, 2020

They get run as part of the PRs submited and avoids a double build

They get run as part of the PRs submited and avoids a double build
@@ -1,6 +1,8 @@
name: JavaScript Linting
on:
push:
branches-ignore:
- "dependabot/**"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh now I see why you are skipping this in PR #1523, approving there and here!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, just avoids those times when an unstable test would pass on the PR and not the branch or vice-versa :)

@mcking65 mcking65 merged commit 51203bd into w3c:master Oct 12, 2020
@nschonni nschonni deleted the disable-dependabot-branch branch October 12, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants