Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menubar Navigation Example: Make single page and improve implementation of APG coding practices #1612

Closed
wants to merge 59 commits into from
Closed

Menubar Navigation Example: Make single page and improve implementation of APG coding practices #1612

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
465bebe
updated menubar navigation
jongund Oct 7, 2020
628ed1e
fixed init bug
jongund Oct 8, 2020
e0dca47
add home link
jongund Oct 8, 2020
0c39184
updated content generator
jongund Oct 8, 2020
0139a36
fixed current page bug
jongund Oct 8, 2020
5bacd89
added aria-owns
jongund Oct 8, 2020
e56eaf4
fixed tabindex bug
jongund Oct 8, 2020
a369fa4
added source code reference
jongund Oct 8, 2020
d77ff40
updated test file to identify tests that need to be updated
jongund Oct 8, 2020
652c7ac
Merge branch 'master' into update-menubar-nav
jongund Oct 20, 2020
08f990c
fixed merge conflicts
jongund Oct 26, 2020
9efae2e
initial implementation of menubar navigation
jongund Oct 26, 2020
20bd934
fixed initilization bug
jongund Oct 26, 2020
76d905c
updated page initialization and aria-current styling
jongund Oct 27, 2020
19f7d05
updated high contrast documentation
jongund Oct 27, 2020
cb78e5f
fixed linting error
jongund Oct 27, 2020
344fcae
fixed linting error
jongund Nov 9, 2020
63e68ad
fixed conflict and merged master
jongund Nov 11, 2020
60cec08
updated menubar navigation example
jongund Nov 11, 2020
88c9ba7
fixed focus bug
jongund Nov 11, 2020
6da5008
deleted commented out code
jongund Nov 11, 2020
3157a89
updated regression tests
jongund Nov 13, 2020
27d1958
updated regression tests
jongund Nov 13, 2020
0609261
fixed conflicts
jongund Nov 18, 2020
f56142e
fixing files that should not be updated
jongund Nov 20, 2020
843c157
fixing files that should not be updated
jongund Nov 20, 2020
ba1d2b0
fixing files that should not be updated
jongund Nov 20, 2020
51fcde6
fixed linting errors
jongund Nov 20, 2020
7668e55
updated aria-current styling
jongund Nov 22, 2020
2805a92
fixed some CSS selector issues
jongund Nov 23, 2020
4c04ee2
fixed some CSS selector issues
jongund Nov 23, 2020
9c6ad53
updated regression tests
jongund Nov 24, 2020
83095af
fixed typeof test
jongund Nov 24, 2020
9aa121c
updated menubar navigation regression tests
jongund Nov 25, 2020
0883938
fixed tag line text
jongund Dec 1, 2020
ae374af
fixed linting bugs
jongund Dec 2, 2020
7169f1f
added a title attribute to menuitems that containg the current page link
jongund Dec 2, 2020
a1f2446
fixed linting issue
jongund Dec 2, 2020
309ad51
Merge branch 'master' into update-menubar-nav
jongund Dec 4, 2020
92a7a7f
changed selectors for header and footer element styling
jongund Dec 4, 2020
446c892
fixed some issues related to coding practices and code pen compatibility
jongund Dec 4, 2020
e946195
fixed code pen issue
jongund Dec 4, 2020
f4ae426
deleted unused files
jongund Dec 14, 2020
f01a8d1
update test cases
jongund Dec 14, 2020
8ac18a0
updated regression tests
jongund Dec 14, 2020
f3d42bb
Merge branch 'master' into update-menubar-nav
jongund Dec 15, 2020
f563e18
updated documentation
jongund Dec 15, 2020
17e0335
Merge branch 'master' into update-menubar-nav
jongund Dec 15, 2020
9822487
updated regression tests
jongund Dec 15, 2020
76e95ca
finished regression tests
jongund Dec 16, 2020
42516f6
updated documentation
jongund Dec 16, 2020
4d1fbf1
updated accessibility documentation
jongund Jan 26, 2021
b4d954b
updated accessibility documentation
jongund Jan 26, 2021
5488c3f
fixing potential conflicts
jongund Jan 26, 2021
7787043
restored test util file
jongund Jan 26, 2021
a5ace11
fixing potential conflicts
jongund Jan 26, 2021
faca380
fixing potential conflicts
jongund Jan 26, 2021
9199504
updated example index file
jongund Jan 28, 2021
5d99d80
Merge branch 'master' into update-menubar-nav
jongund Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 56 additions & 3 deletions examples/menubar/css/menubar-navigation.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,51 @@
#ex1 header {
spectranaut marked this conversation as resolved.
Show resolved Hide resolved
border: #005a9c solid 2px;
background: #005a9c;
color: white;
text-align: center;
}

#ex1 header .title {
font-size: 2.5em;
font-weight: bold;
font-family: serif;
}

#ex1 header .tagline {
font-style: italic;
}

#ex1 .main {
padding-top: 1em;
padding-left: 5%;
padding-right: 5%;
padding-bottom: 5em;
border-left: 2px solid #eee;
border-right: 2px solid #eee;
}

#ex1 footer {
border: #005a9c solid 2px;
background: #005a9c;
font-family: serif;
color: white;
font-style: italic;
padding-left: 1em;
}

#ex1 nav {
margin: 0;
padding: 0;
border: 2px solid #eee;
}

.menubar-navigation {
margin: 0;
margin-top: 0.5em;
margin-bottom: 0.5em;
padding: 7px;
font-size: 110%;
list-style: none;
background-color: #eee;
border: #eee solid 1px;
border-radius: 5px;
}

.menubar-navigation li {
Expand Down Expand Up @@ -92,6 +130,21 @@
background-repeat: repeat-x;
}
spectranaut marked this conversation as resolved.
Show resolved Hide resolved

/* aria-current styling */

.menubar-navigation [role="menuitem"][aria-current]::after {
content: url("../images/aria-current.svg");
position: relative;
left: 4px;
}

.menubar-navigation [role="menuitem"][aria-current] {
padding: 4px;
border: 2px solid #9c4200;
background-color: #9c4200;
color: white;
}

/* focus styling */

.menubar-navigation.focus {
Expand Down
Loading