-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disclosure: Distinguish the widget from the control #1880
Disclosure: Distinguish the widget from the control #1880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I think this does make it clearer. :)
Thanks, @jonathantneal !
Thanks, @carmacleod! Is there anything else I can do to help keep this PR moving along, or to help get it placed into the right queue for additional approval or rejection? I’m unsure if there is more to the process that I should be doing. I hope this ping is helpfully persistent, or rather that it is not annoyingly impatient! 😄 |
@jonathantneal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. The task force discussed it at this week's meeting.
We agree with the issue. We had two concerns with the proposal as is:
- It didn't make it really clear that the disclosure widget has 2 elements.
- The word "typically" implied the control could be something other than a button.
I have proposed some revisions to address these concerns. Please accept or revise them.
Co-authored-by: Matt King <[email protected]>
Co-authored-by: Matt King <[email protected]>
Co-authored-by: Matt King <[email protected]>
Sorry for the delay. Thank you for discussing my PR for offering revisions. I’ve accepted all of them. Let me know if there is anything else I can do to help keep this PR moving along. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonathantneal thank you for raising this issue and proposing the changes!
This PR updates the document to distinguish the disclosure widget from the disclosure control.
At first, the document refers to the disclosure as the button, but then later refers to that button as the disclosure control.
Note: If widget is not the appropriate term, the disclosure examples [1] [2] [3] [4] refer to it as a design pattern.
Preview | Diff