Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: update globs for file moves #2467

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Sep 5, 2022

Updates the globs for ESLint and cSpell so the CI goes green again after the moves

@nschonni nschonni changed the base branch from main to move-examples September 5, 2022 06:47
@nschonni nschonni changed the title chore: update globs for file move Infrastructure: update globs for file moves Sep 5, 2022
@nschonni
Copy link
Contributor Author

nschonni commented Sep 5, 2022

@mcking65 this should make the other move-examples PRs easier to review, since the CI will flag new issues rather than ones that were previously ignored

@mcking65
Copy link
Contributor

mcking65 commented Sep 6, 2022

@nschonni

wish I would have seen and merged this before I worked on the table pattern file. I just added the missing tag. So, it should be a snap to rebase this. Other changes look great, thank you!

@mcking65
Copy link
Contributor

mcking65 commented Sep 6, 2022

I just pushed commit to remove aria-practices-DeletedSectionsArchive.html from the move-examples branch.

It's is the time and place to make that change, finally!

@nschonni
Copy link
Contributor Author

nschonni commented Sep 6, 2022

wish I would have seen and merged this before I worked on the table pattern file. I just added the missing tag. So, it should be a snap to rebase this. Other changes look great, thank you!

@mcking65 I rebased out the tag change for this one

I just pushed commit to remove aria-practices-DeletedSectionsArchive.html from the move-examples branch.

OK, I'll go update my review on that other PR then

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nschonni

@mcking65 mcking65 merged commit 162c743 into w3c:move-examples Sep 6, 2022
@nschonni nschonni deleted the move-examples-globs branch September 6, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants