Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox Pattern: Simplify wording of description in "About This Pattern" section #2733

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Jun 26, 2023

This PR replaces #2375.

In the "About This Pattern" section of the Combobox Pattern:

  • Simplified wording of the first sentence, breaking it int two sentences.
  • Divided first paragraph into two paragraphs
  • Changed order of sentences.

Preview

View the revised combobox pattern in the compare branch of this PR

Review checklist


WAI Preview Link (Last built on Mon, 26 Jun 2023 03:25:16 GMT).

@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. documentation Pattern Page Related to a page documenting a Pattern labels Jun 26, 2023
@mcking65 mcking65 added this to the H1/2023 Content Updates milestone Jun 26, 2023
@mcking65
Copy link
Contributor Author

@tinynow

We restructured the entire repository, so this is a replacement for your suggestion in #2375.

Copy link
Member

@jnurthen jnurthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed PR2733: Combobox Pattern: Simplify wording of description in "About This Pattern" section by mcking65.

The full IRC log of that discussion <jugglinmike> subtopic: PR2733: Combobox Pattern: Simplify wording of description in "About This Pattern" section by mcking65
<jugglinmike> github: https://github.com//pull/2733
<jugglinmike> Matt_King: This is an editorial change; I tried to simplify some wording based on feedback we received
<jugglinmike> Matt_King: The changes are all in the first two paragraphs for the Combobox pattern
<Matt_King> p1: A combobox is an input widget that has an associated popup. The popup enables users to choose a value for the input from a collection. The popup may be a
<Matt_King> listbox, grid, tree, or dialog.
<jugglinmike> s/p1:/paragraph 1 reads:/
<jugglinmike> Matt_King: If no one sees any typos, then I'd appreciate an approval on the pull request so that we can move forward
<jugglinmike> Matt_King: The other change was spreading the text into two paragraphs

@mcking65 mcking65 merged commit e716cc2 into main Jul 10, 2023
@mcking65 mcking65 deleted the combobox-description branch July 10, 2023 21:20
@mcking65 mcking65 added the enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Pattern Page Related to a page documenting a Pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants