Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sortable Table Example: Separate off-screen portion of caption with parenthesis instead of comma #3072

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

ariellalgilmore
Copy link
Contributor

@ariellalgilmore ariellalgilmore commented Jul 30, 2024

Fixes #3066

updating sr-only text to parenthesis instead of a comma

Preview

Preview Sortable Table Example in compare branch


WAI Preview Link (Last built on Tue, 27 Aug 2024 02:57:06 GMT).

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for One small change.

content/patterns/table/examples/sortable-table.html Outdated Show resolved Hide resolved
@mcking65 mcking65 changed the title fix comma on sortable table example to parenthesis Sortable Table Example: Separate off-screen portion of caption with parenthesis instead of comma Aug 6, 2024
@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Sortable table caption.

The full IRC log of that discussion <jugglinmike> Topic: Sortable table caption
<jugglinmike> github: https://github.com//pull/3072
<jugglinmike> Matt_King: In the sortable table example, there's a caption on the table. The capture: a phrase, followed by a comma, followed by another phrase
<jugglinmike> Matt_King: Someone pointed out that the comma is not a very good syntactic structure because the comma is off-screen
<jugglinmike> Matt_King: So we're removing it in favor of using a space as a separator
<jugglinmike> Matt_King: At the moment in the patch, though, even though I can observe a space in the code, JAWS appears to be rendering without the space
<jugglinmike> arigilmore: I haven't had a chance to investigate further since you reported that, though I know there's no problem with VoiceOver. I'll be sure to look into it with JAWS
<jugglinmike> s/into it/in to it/
<jugglinmike> Matt_King: I didn't try this in Firefox, actually
<jugglinmike> Matt_King: Firefox has TWO spaces!
<jugglinmike> Adam_Page_: I remember a similar issue coming up on a WPT test that I wrote. Something to do with a link or a button, if I recall correctly
<jugglinmike> Matt_King: This might be a browser bug and no problem with arigilmore's code
<jugglinmike> arigilmore: Interesting...
<jugglinmike> Adam_Page_: Reviewing the pull request, now, I can see a space at the beginning of the "span" element
<jugglinmike> arigilmore: What do you think if I use an HTML entity like "&nbsp;"?
<jugglinmike> Adam_Page_: I was thinking about that, too; you might also try the "breaking space" entity (although it probably doesn't matter too much because this is off-screen)
<jugglinmike> Matt_King: Yeah, let's try an entity, arigilmore

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now, thanks @ariellalgilmore!

@mcking65 mcking65 merged commit 916fd65 into w3c:main Aug 27, 2024
11 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/table-sortable-text branch August 28, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comma on Sortable Table Example
4 participants