-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation concerns over Orphaned Role requirements in Core-AAM, HTML-AAM… and possibly elsewhere. #2166
Comments
Discussed briefly during new issue triage: https://www.w3.org/2024/04/25-aria-minutes.html#t01 |
Aside from the implementation concerns, a user has reported that this does change behaviour for sites in the wild. See this Mastodon thread. Examples include the stories list in Instagram and the navigation bar on the Synchresis Solutions website. Obviously, those sites are violating the spec, but enforcing this in Firefox has changed things unexpectedly for that user, and I'm not sure that's a good thing. I'd argue that backwards compatibility trumps correctness in this case, especially given that there are other concerns here. |
Proposed for deep dive on July 11, 2024 - led by @cookiecrook |
FWIW, we are pulling those WPT tests out to tentative with this PR. Only Gecko has implemented the change so far (and is reconsidering, see above). WebKit does not plan to implement. I haven't heard definitively from @aleventhal, @dtsengchromium, or others at Chromium, but I expect they will not want to implement the change given the other concerns and soon-to-be-removed WPT tests. |
I believe @tranjocelyn has already implemented this in Chromium. |
Approximately half have been implemented so far in Chromium, specifically the ones in roles-generic, grid-roles, and list-roles. |
It's possible that not all of these rules are harmful. Should we look at these one by one or just carte blanche axe them all? |
@aleventhal wrote:
For the sake of tomorrow's Deep Dive discussion, the list of core ARIA roles with "Required Accessibility Parent Roles" is below. There are likely more in HTML-AAM and other AAM specs. |
DPUB-ARIA or DPUB-AAM may have some too... as one example:
|
|
All implementors (and other WG members) in the call today concluded to remove the Core-AAM RFC requirement here:
…and replace it with either a note (or perhaps an RFC MAY) explaining that this remains an author error, but the spec is permissive in the way user agents attempt to reconcile this error for the benefit of users. The WPT tests will removed with comments pointing to this new note and related issues. If and when there is a reason to address one of these instances individually (for example, #2137 or other specific behavior defined in HTML-AAM), we should discuss those individually, rather than broadly disallowing the implementations to repair an author error. |
@scottaohara was not able to make the meeting, but expressed some concern about the conclusion afterwards. He and I will meet tomorrow to discuss, and I'll share another update. |
and just to clarify that - my concerns are specific to HTML element implicit roles. i'm not overly concerned with this decision for explicit author defined ARIA roles. |
just spoke with @cookiecrook and we confirmed that the agreed upon update to core aam is fine, and that that update doesn't necessarily mean that any current / proposed behavior for HTML elements which have/could have contextual roles need to be altered. we will do a review/re-review of the contextual roles of HTML regardless. but if anything needs to change there, it'll be a separate effort than the decision that was made about the core aam change. |
The requirement for elements to be in their required context (for example, for a listitem to be inside a list) is no longer enforced, so the check for expected parent roles can be removed. [1] w3c/aria#2166 Change-Id: I8f9f64e0064de4229c93517563fb13b488663e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5710051 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Jocelyn Tran <[email protected]> Cr-Commit-Position: refs/heads/main@{#1332333}
Core-AAM Spec prose:
Cite: https://w3c.github.io/core-aam/#roleMappingComputedRole
While working through WPT tests for Interop 2024, we've received some additional implementation concerns about the "orphaned roles" prose. Seems like one or more implementations may be working around this in the test context primarily, which defeats the purpose of testing… I'm opening this new ARIA issue and possibly moving some of these tests to .tentative files.
Some Concerns
display:contents
), where a parent's implicit role may may change due a responsive layout update, causing a cascade of role and style dependencies below. Sometimes a descendant may be disconnected from it's parent context inadvertently, putting additional work on the web engine's accessibility implementation to invalidate the role of an item unexpectedly...aria-owns
from elsewhere in the DOM.Since the ~"orphaned roles must be invalidated" rule is a relatively new requirement, and since there have been a few implementation concerns raised, I suggest we move those tests to
.tentative
and bring them back once concerns are resolved or the issue is otherwise closed.The text was updated successfully, but these errors were encountered: