provide 2 options to log in with different app privileges #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
any chance you could add tests to match the new API end point and the new login flow?
Also, I think #164 suggested not even requiring public_repo and instead post a comment from the app's login (rather than the user), but @-mentioning the logged-in user - that could be done as a further iteration without blocking this PR which is already a huge improvement.
* comment on behalf of the user with w3cbot
|
The PR now uses @w3cbot to comment on behalf of the user (a token will need to be generated with |
dontcallmedom
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repository manager currently asks for the following privileges:
From the scope documentation,
public_repois enough to comment on behalf of the user.The
write:repo_hookis only necessary if you need to import/create a repository.That PR provides limits the privileges we asked the regular contributors and provides an alternate link asking for more access for people who wish add a new repository.
Fix #164