Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update PR IPR status if GH signature doesn't match secret #212

Merged
merged 2 commits into from
Aug 27, 2021
Merged

update PR IPR status if GH signature doesn't match secret #212

merged 2 commits into from
Aug 27, 2021

Conversation

deniak
Copy link
Member

@deniak deniak commented Aug 27, 2021

No description provided.

dontcallmedom
dontcallmedom approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@dontcallmedom dontcallmedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be good to add tests

@deniak
Copy link
Member Author

deniak commented Aug 27, 2021

Glad you asked for a test as it showed that the PR wasn't working properly.

@deniak deniak merged commit bcacc56 into master Aug 27, 2021
@deniak deniak deleted the surface-signature-error branch August 27, 2021 14:29
@erik-anderson erik-anderson mentioned this pull request Aug 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dontcallmedom dontcallmedom dontcallmedom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deniak @dontcallmedom