Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-fonts-5] Is the 'size-adjust' descriptor stable enough to ship? #6371

Closed
jfkthame opened this issue Jun 9, 2021 · 7 comments
Closed

Comments

@jfkthame
Copy link
Contributor

jfkthame commented Jun 9, 2021

We have implemented https://drafts.csswg.org/css-fonts-5/#size-adjust-desc in Firefox nightly builds, and it seems to work fine.

Do we consider the spec for this feature stable enough to ship, or should we hold it back as nightly-only for a while yet?

@fantasai
Copy link
Collaborator

fantasai commented Jun 9, 2021

Probably should merge in outstanding edits and publish FPWD first, but, it seems fairly straightforward otherwise?

@svgeesus
Copy link
Contributor

svgeesus commented Jun 9, 2021

I agree with @fantasai that clearing up the needs edits and resolving on FPWD should be done first (but soon!).

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed CSS Fonts 5: font-size-adjust.

The full IRC log of that discussion <fantasai> topic: CSS Fonts 5: font-size-adjust
<fantasai> github: https://github.com//issues/6371
<fantasai> s/font-size-adjust/size-adjust/
<fantasai> jfkthame: We've implemented size-adjust descriptor in Firefox Nightly, and want to know if stable enough if we can ship to release
<fantasai> jfkthame: My understanding is that Chrome is also wanting to ship soon
<chrishtr> agree it's good to ship
<astearns> ack fantasai
<fremy> fantasai: I think the descriptor is pretty stable
<fremy> fantasai: the way it is defined is standard and I don't anticipate issues
<fremy> fantasai: so I think it's probably fine to ship
<fremy> fantasai: but we need to publish a First Public working draft first
<fremy> fantasai: this could happen very soon
<fantasai> astearns: Any other concerns?
<fantasai> smfr: let's ask Myles, he's not here today
<fantasai> astearns: Sounds good, also we still need an FPWD
<fantasai> https://www.w3.org/TR/css-fonts-5/
<fantasai> 404 ^
<fantasai> astearns: It's most important to publish FPWD, but even for a regular WD would like to publish before group says "you can ship" :)
<fantasai> astearns: So let's get edits in and get Myles' comments
<fantasai> astearns: but generally seems like it'll be OK
<fantasai> jfkthame: Would help to know schedule
<fremy> fantasai: we can get a draft within a month

@jfkthame
Copy link
Contributor Author

@litherum, could you confirm whether you're OK with this, or have any concerns? Thanks!

@astearns astearns removed the Agenda+ label Jun 16, 2021
@chrishtr
Copy link
Contributor

Shall we close this issue now? It seems done.

@svgeesus
Copy link
Contributor

svgeesus commented Aug 19, 2021

The only related open issues are

Add font-size descriptor to @font-face which allows ranges (for optical sizing) which, I think, is mainly confusing properties and descriptors. It is an older issue and predates a lot of changes in the spec. That issue can probably be closed.

font-size Descriptor for ex Unit which is again old and I think is satisfied by the newly-expanded font-size-adjust.

And the FPWD mentioned earlier in this issue has been published, a while ago (2021-06-29) and updated since.

I would be okay with closing this issue.

@chrishtr
Copy link
Contributor

Ok I'll go ahead and close this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants