-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-text-4] Is hyphenate-character stable enough to ship? #6887
Labels
Comments
CC @kojiishi |
The CSS Working Group just discussed
The full IRC log of that discussion<TabAtkins> Topic: can we ship hyphenate-character?<TabAtkins> jfkthame: Question in the title <TabAtkins> jfkthame: webkit and blink have this, but -webkit- prefixed <TabAtkins> astearns: And Firefox has this unprefixed? <TabAtkins> jfkthame: Yes, behind a nightly flag <TabAtkins> jfkthame: So quesiton is whether we can ship it unflagged <TabAtkins> fantasai: I think so. I don't remember there being any issues against this particular property for the many years it's been around <TabAtkins> florian: Agree. You noted there might need to be extensions later to be smart about some details, but they can be put on top of the current value set <TabAtkins> astearns: What's state of the spec? <TabAtkins> florian: WD, this is level 4 <TabAtkins> astearns: So we resolve this is okay to publish, and add this to the snapshot list of things that are shippable ahead of process <TabAtkins> astearns: objections? <TabAtkins> RESOLVED: hyphenate-character is shippable; we'll add it to the Snapshot 2022 list of exceptions <TabAtkins> fantasai: Do we want to resolve to publish a Draft Note 2022 with this change? <TabAtkins> astearns: I think we should publish as needed, yes. <TabAtkins> chris: Seems much better to publish as we ahve updates, yes <TabAtkins> astearns: So proposed reoslution is we publish a Draft Note for 2022 <fantasai> (Now that we have a Draft Note) <TabAtkins> chris: since /TR/CSS goes to the snapshot, why don't we publish a NOte series with "css" as the shortname, so every time it's not the first draft, but just an update? <TabAtkins> fantasai: I didn't like this; I think it's useful to have snapshots on a yearly basis <TabAtkins> fantasai: Just walking back thru publish history isn't the same <TabAtkins> chris: If you follow history right now, it'll say "css 2022 has been published once", and you can't go back to 2021 from there <TabAtkins> fantasai: I think your point is valid but it is true for all leveled/versioned things <TabAtkins> fantasai: That's an issue for the templates <TabAtkins> astearns: So no reoslution, we'll break |
frivoal
pushed a commit
that referenced
this issue
Jan 31, 2022
Includes 'hyphenate-character' as a shippable property, as per #6887
webkit-commit-queue
pushed a commit
to joonghunpark/WebKit
that referenced
this issue
May 27, 2023
https://bugs.webkit.org/show_bug.cgi?id=243670 Reviewed by Tim Nguyen. This change supports unprefixed hyphenate-character, not only -webkit-hyphenate-character. According to the csswg discussion, w3c/csswg-drafts#6887, hyphenate-character css property is stable enough to ship. * LayoutTests/TestExpectations: * LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt: * LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * LayoutTests/fast/css/getComputedStyle/resources/property-names.js: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-003-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-003.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-004-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-004.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-005-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-005.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-limit-chars-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-limit-chars-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-003-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-003.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-and-contenteditable-crash.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-control-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-control.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-character-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-character.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-010.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-011.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-012.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-013.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-inline-010.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-inline-011.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-inline-012.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-011.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-012-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-012.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-013-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-013.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-014-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-014.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-015-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-015.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-out-of-flow-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-out-of-flow-002.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-punctuation-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-punctuation-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-shaping-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-shaping-002.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-span-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-span-002.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-003-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-003.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-004-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-004.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/shy-styling-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/hyphenate-character-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/hyphenate-character-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/hyphenate-limit-chars-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/hyphens-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/hyphens-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/hyphens-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * LayoutTests/platform/wpe/TestExpectations: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/svg/css/getComputedStyle-basic-expected.txt: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * Source/WebCore/editing/cocoa/HTMLConverter.mm: (HTMLConverter::computedAttributesForElement): * Source/WebCore/style/PropertyAllowlist.cpp: (WebCore::Style::isValidMarkerStyleProperty): Canonical link: https://commits.webkit.org/264628@main
mnutt
pushed a commit
to movableink/webkit
that referenced
this issue
Jun 28, 2023
https://bugs.webkit.org/show_bug.cgi?id=243670 Reviewed by Tim Nguyen. This change supports unprefixed hyphenate-character, not only -webkit-hyphenate-character. According to the csswg discussion, w3c/csswg-drafts#6887, hyphenate-character css property is stable enough to ship. * LayoutTests/TestExpectations: * LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt: * LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * LayoutTests/fast/css/getComputedStyle/resources/property-names.js: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-003-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-003.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-004-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-004.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-005-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-005.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-limit-chars-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-limit-chars-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-003-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-003.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-and-contenteditable-crash.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-control-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-control.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-character-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-character.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-010.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-011.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-012.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-013.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-inline-010.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-inline-011.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-manual-inline-012.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-011.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-012-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-012.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-013-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-013.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-014-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-014.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-015-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-015.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-out-of-flow-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-out-of-flow-002.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-punctuation-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-punctuation-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-shaping-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-shaping-002.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-span-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-span-002.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-003-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-003.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-004-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-vertical-004.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/hyphens/shy-styling-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/hyphenate-character-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/hyphenate-character-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/hyphenate-limit-chars-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/hyphens-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/hyphens-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/hyphens-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * LayoutTests/platform/wpe/TestExpectations: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/svg/css/getComputedStyle-basic-expected.txt: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * Source/WebCore/editing/cocoa/HTMLConverter.mm: (HTMLConverter::computedAttributesForElement): * Source/WebCore/style/PropertyAllowlist.cpp: (WebCore::Style::isValidMarkerStyleProperty): Canonical link: https://commits.webkit.org/264628@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm interested in implementing the
hyphenate-character
property in Gecko.Checking other browsers, I see that both Webkit and Blink have this property, but with the prefixed name
-webkit-hyphenate-character
; the non-prefixed version does not appear to be supported.So... should we consider
hyphenate-character
stable enough that it's OK to implement and ship as an unprefixed property (and create some corresponding web-platform-tests), or would this be premature?I see there has been some discussion (e.g. #2975) of additional potential values, e.g. to support cases where hyphenation inserts a character after the line-break in addition to (or instead of) before the break. But I don't think this needs to block shipping of the simple property as currently spec'd; a future extension could still introduce a two-valued syntax, for example, without affecting the current single-valued syntax.
The text was updated successfully, but these errors were encountered: