Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cssom-1] Simplify setting MediaList.mediaText #10014

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cdoublev
Copy link
Collaborator

@cdoublev cdoublev commented Feb 29, 2024

This PR removes step 2 for setting MediaList.mediaText with empty string since step 3 (parsing) produces the same outcome:

  1. Append all the media queries as a result of parsing the given value to the collection of media queries.

Parsing links to parse a media query list which redirects to <media-query-list>:

To parse a <media-query-list> production, parse a comma-separated list of component values, then parse each entry in the returned list as a <media-query>.

Note: This definition of <media-query-list> parsing intentionally accepts an empty list.

Note that the entire procedure could be replaced with "replace the collection of media queries with the result from parsing the given value", since this collection is not exposed nor shared with another interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant