-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-ui] Disallow internal pseudo-elements and 'appearance' values #3968
base: main
Are you sure you want to change the base?
Conversation
Pseudo-elements for internal parts of controls (e.g., `::-webkit-search-cancel-button`) and related 'appearance' values (e.g., `searchfield-cancel-button`) must not be exposed to author origin CSS or in `getComputedStyle()`. If user agents find that they can't remove support for something, the pseudo-element and the appearance value should both be specified. Tests: - 'appearance' values: already covered by css/css-ui/appearance-cssom-001.html - pseudo-elements: TODO - getComputedStyle: TODO Part of w3c#3024.
Wait, what? You are requiring getComputedStyle to not work on any possible property on an unbound set of pseudo-elements? This is wild, and absolutely not something that seems up for discussion or suggested by anyone as far as I'm concerned. The only changed required is that the appearance property on those pseudos must return a value that is supported by the property, and that is absolutely logical and shouldn't require any specific text except maybe a note; browsers who support special values internally can convert those values to 'auto' if those pseudos currently have a proprietary value today (either for real, or just for gCS purposes). But in the test you verify that zIndex lies to author about having a value it actually has, this is significantly way beyond the scope of speccing the appearance property. |
Well there's also no spec for those pseudo-elements, and What I tried to address here is the concern raised at the 2018 TPAC f2f, about what I can file a new issue for CSSOM to discuss this. |
@@ -1888,6 +1869,23 @@ Animation type: discrete | |||
|
|||
</dl> | |||
|
|||
Some controls have internal parts, or sub controls. | |||
For example, an <code class="lang-markup"><input type=search></code> element | |||
could have a clear button to clear the text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this context, "a clear button" might be taken to mean "a button with no background color." Scare quotes would help avoid this ("a "clear" button") as would removing the adjective altogether (which seems acceptable given the phrase is immediately followed by a description of the button's purpose).
I'm marking this "Needs Design / Proposal" to indicate that this PR is blocked on a resolution of #3980 |
Yes, I think you are correct, or more simply, the css-ui spec could require such values to be the |
Pseudo-elements for internal parts of controls (e.g.,
::-webkit-search-cancel-button
)and related 'appearance' values (e.g.,
searchfield-cancel-button
)must not be exposed to author origin CSS or in
getComputedStyle()
.If user agents find that they can't remove support for something,
the pseudo-element and the appearance value should both be specified.
Tests:
Part of #3024.
cc @tkent-google @foolip @MatsPalmgren @emilio @jwatt